Search results include pages with empty titles

18F / 18f.gsa.gov

The 18F website

https://18f.gsa.gov

Other

293 stars 311 forks source link

Search results include pages with empty titles #2109

Closed gboone closed 7 years ago

gboone commented 7 years ago

Expected Behavior

A search results page like this one should only show results with page titles and navigable page paths.

Actual Behavior

Search results contain some pages with no title, and no clickable link.

Steps to reproduce the behavior

[ ] Do a search, any will do but here's an example and look for results like 1.

This is issue is done when:

[x] All results of a search are clickable links

gemfarmer commented 7 years ago

Ok, so after a bit more research, this appears to be caused by a few things

files that weren't excluded in the build (contributing.md, for example) get indexed
built redirect pages get built and are indexed. Adding skip_index: true to the frontmatter should prevent this, but several of the redirect_from pages don't have frontmatter.

gemfarmer commented 7 years ago

Appears that adding skip_index: true to dead pages works, the site just wasn't building properly.

Also, I am adding the results UI script to the javacript include so that we can filter the results. This will have the added benefit of allowing us to redesign the blog search results UI.

coreycaitlin commented 7 years ago

I believe this is solved in release 1.1.3