18F / 18f.gsa.gov

The 18F website
https://18f.gsa.gov
Other
289 stars 310 forks source link

Add pa11y scanner #3949

Closed beechnut closed 2 weeks ago

beechnut commented 2 weeks ago

Previously, we did accessibility scanning for every file in every push / build / PR, which took > 25 mins each run.

Now, we more carefully curate the files that need to be scanned, to limit the scan time.

This PR:

Commentary:

This commit gets us to the "Make it work" stage, not yet addressing "Make it right" or "Make it fast".

The code also reads a little weird, and I'm not sure a conditional "eleventy.after" event is the right design for this. I think one more refactor here would be wise.

Closes #3875

caleywoods commented 2 weeks ago

I added some non blocking suggestions related to readability, this feels like a great start Matt!