replatform: missing aria-label

[cantsin]

Example:

--- original/work-with-us/index.html    2024-08-06 08:24:30.365013882 -0700
+++ changed/work-with-us/index.html 2024-08-06 08:32:33.406031045 -0700

-      <div aria-label="Agency description" class="usa-identifier__identity text-base-lightest">
+      <div class="usa-identifier__identity text-base-lightest">
        <p class="usa-identifier__identity-domain">
         18f.gsa.gov
        </p>

[beechnut]

When we brought over the templates from 18F/guides, this "usa identifier" footer came with it. I suspect that this change came from using the guides' templates.

We can see in this screenshot that the guide name does not have the alt attribute:

The prime directive of this migration is to have no content changes meaningful enough to have to go through any approval. A secondary directive is to try to have some parity with the guides, since they act as the same site.

@cantsin I'm guessing there are 1000+ instances of this attribute going missing from the footer, but are there any other aria-labels that have gone missing? I'm wondering if the fix is just to add it back here, and to open a parallel issue for the guides.

[cantsin]

There are no other aria-labels missing, as far as I know. The fix indeed here is to add aria-label for the footer and yes, we should fix this on guides as well.

[cantsin]

Apologies for the noise, this aria-label is a misuse on 18f.gsa.gov 😞