18F / 18f.gsa.gov

The 18F website
https://18f.gsa.gov
Other
293 stars 311 forks source link

replatform: footnotes missing role attributes #4048

Closed cantsin closed 3 months ago

cantsin commented 3 months ago

Example file:

--- original/2014/05/29/announcing-the-developer-program-a-new-hub-for/index.html   2024-08-09 08:51:38.647770191 -0700
+++ changed/2014/05/29/announcing-the-developer-program-a-new-hub-for/index.html    2024-08-09 08:49:48.802726602 -0700

I believe doc-endnote is deprecated But we probably want to keep doc-endnotes (source) and doc-backlink (source).

looking at this, this is sufficiently complicated that I'm not sure 18f.gsa.gov is doing the right thing with a11y anymore vis a vis footnotes. I have questions about the structure itself and if that still works for screen readers. Maybe we should punt on this after the release (once we have a11y testing in place)

-       <div class="footnotes" role="doc-endnotes">
-        <ol>
-         <li id="fn:1" role="doc-endnote">
+       <section class="footnotes">
+        <ol class="footnotes-list">
+         <li class="footnote-item" id="fn1">
           <p>
            This was recommended in the
            <a href="https://obamawhitehouse.archives.gov/sites/default/files/omb/egov/digital-government/digital-government.html#open-data-default">
             Digital Government Strategy
            </a>
            .
-           <a class="reversefootnote" href="#fnref:1" role="doc-backlink">
-            ↩
+           <a class="footnote-backref" href="#fnref1">
+            ↩︎
            </a>
           </p>
          </li>