search

18F / 18f.gsa.gov

The 18F website
https://18f.gsa.gov
Other
293 stars 311 forks source link

replatform: emails should not have external link? #4055

Closed cantsin closed 1 month ago

cantsin commented 1 month ago

this one may be up to debate but bringing it up because it is an oddity: the email links have usa-link--external tagged on them.

20240812_10h41m52s_grim

beechnut commented 1 month ago

No debate from me: this is weird and I don't understand why it's happening, but I have a suspicion about who's (= which software module) is responsible.

beechnut commented 1 month ago

Ok, the culprit here is the markdown renderer override markdownLibrary.renderer.rules.link_open. It's handling mailto links incorrectly, checking its hostname when it doesn't have a hostname.