18F / 2015-foia-hub

A consolidated FOIA request hub.
Other
48 stars 17 forks source link

QA Check #538

Closed rjmajma closed 9 years ago

rjmajma commented 9 years ago

I wanted to expand on the work done in #445 and take a look at the site as a whole. PR #537 fixes the things I could identify and work on. The following require fixes I can't implement.

Found a bug in the first reading room link for BSEE. Currently takes you to https://foia.18f.us/About-BSEE/FOIA/BSEE-FOIA-Reading-Room/.

screen shot 2015-02-24 at 12 54 19 am

rjmajma commented 9 years ago

Additional bug found with CFTC. First link takes you to https://foia.18f.us/FOI/foiareadingrooms.

screen shot 2015-02-24 at 12 58 25 am

rjmajma commented 9 years ago

CEQ reading room links take you to the same location (not distinguished from proactive disclosure versus foia disclosure). http://www.whitehouse.gov/administration/eop/ceq/foia/readingroom

screen shot 2015-02-24 at 1 00 54 am

rjmajma commented 9 years ago

Same issue from above with DNFS. Also an error with the display of the first link. http://www.dnfsb.gov/foia-reading-room

screen shot 2015-02-24 at 1 02 14 am

rjmajma commented 9 years ago

EPA's reading rooms are a bit of a mess. Some regional offices have a few broken links. Consolidating this per #539 may help. Either way, they should not link to http://www2.epa.gov/foia. They should link to FOIA Online, as that's where the library is.

rjmajma commented 9 years ago

EXIM links to the wrong website location. This is where it should go: http://www.exim.gov/about/library/foia/

screen shot 2015-02-24 at 1 10 47 am

rjmajma commented 9 years ago

FSCIC also repeats.

screen shot 2015-02-24 at 1 15 33 am

rjmajma commented 9 years ago

FEMA's FOIA page is broken. It's listed correctly, just doesn't work. Thoughts?

Also, the request page is incorrect. It should send here: https://www.fema.gov/submit-foia-request-nac-information

screen shot 2015-02-24 at 1 18 46 am

rjmajma commented 9 years ago

FERC's submit link is incorrect. I believe it should send here: http://www.ferc.gov/legal/ceii-foia/foia/foia-new-form/FOIARequest.aspx

screen shot 2015-02-24 at 1 19 46 am

rjmajma commented 9 years ago

FLETC library has two links (both of which are broken. Not our mistake).

screen shot 2015-02-24 at 1 23 41 am

rjmajma commented 9 years ago

FOMC "Reading Rooms" link should be removed. Each link takes you to the same page. What's most useful is to keep the other two links because they at least take you to their respective spots on the same FOMC page.

screen shot 2015-02-24 at 1 26 38 am

rjmajma commented 9 years ago

FTC reading room has duplicates. Remove the last link.

screen shot 2015-02-24 at 1 27 41 am

rjmajma commented 9 years ago

FLRA Dallas and Denver regional offices have the same email address. Not sure if this is correct. Can you do a quick spot check @ramirezg?

rjmajma commented 9 years ago

JPL site link should be fixed to send the user here: http://www.hq.nasa.gov/office/pao/FOIA/jpl/index.htm

(updated to include the correct link)

screen shot 2015-02-24 at 1 31 54 am

rjmajma commented 9 years ago

Marine Corps reading room links are labeled differently but take you to the same place.

screen shot 2015-02-24 at 1 33 24 am

rjmajma commented 9 years ago

NTSB FOIA library link is incorrect. It ends with .html but should be: http://www.ntsb.gov/about/foia/Pages/foia_err.aspx.

The main site link has a similar problem and should go here: http://www.ntsb.gov/about/foia/Pages/default.aspx

screen shot 2015-02-24 at 1 47 48 am

rjmajma commented 9 years ago

NSA email duplicated for some reason. One should be removed.

screen shot 2015-02-24 at 1 48 50 am

rjmajma commented 9 years ago

NRO email is duplicated as well. One should be removed.

screen shot 2015-02-24 at 1 49 28 am

rjmajma commented 9 years ago

NHTSA request online link should be removed. The agency has no web form (that I have found) and it only provides information on how to email/write the agency.

screen shot 2015-02-24 at 1 52 41 am

rjmajma commented 9 years ago

NARA has a few weird points. The true regional offices do not have reading room links. We should consider adding them.

Another issue is that Accessioned Executive Branch Agency Records - Washington, DC Area, Main Office, and OIG both have two reading room links that take you to the same place. One should be removed.

screen shot 2015-02-24 at 1 56 52 am

geramirez commented 9 years ago

@rjmajma Nice catch noticing that the FLRA Dallas and Denver regional offices have the same email. This is actually an error on foia.gov, which we can fix in the manual data.

geramirez commented 9 years ago

JPL site link should be fixed to send the user here: http://www.fmcs.gov/internet/itemDetailNoNav.asp?categoryID=90&itemID=16303

@rjmajma wait, why should JPL link to FMCS?

geramirez commented 9 years ago

NSA email duplicated for some reason. One should be removed.

@rjmajma I'll look into this.

geramirez commented 9 years ago

NHTSA request online link should be removed. The agency has no web form (that I have found) and it only provides information on how to email/write the agency.

@rjmajma I think the form pops up when you click here it's just not very descriptive though.

screen shot 2015-02-24 at 10 53 24 am

rjmajma commented 9 years ago

Hey @ramirezg:

Wrong link to JPL. It should be this: http://www.hq.nasa.gov/office/pao/FOIA/jpl/index.htm. I'll fix in the comment as well.

That's a shame about NHTSA. Keep it.

geramirez commented 9 years ago

@khandelwal I see that you're assigned to this issues, but I have some time today so I can take care of the following:

khandelwal commented 9 years ago

Figure out how the duplicate emails get in there, and ensure that the software doesn't let that happen again. I'm guessing we don't check to see if it's already in there somewhere.

geramirez commented 9 years ago

Ok, took care of the issues here 18F/foia/pull/104 and found the source of the email dups. I'm updating the contacts now.

khandelwal commented 9 years ago

A lot of the issues reported in here should now be fixed. Let's check them (and then close this issue).