Resurrect small search - Githubissues

shawnbot commented 9 years ago

OK, small search is back with a vengeance. Some ugly stuff happened in 9421be7 that I don't want to talk about, but check out these snazzy screenshots!

@ericadeahl: I went ahead and replaced the clear button with a submit button, but I don't really like how the two arrows sit on top of one another. Maybe replace the top arrow with the word "it"? (Would an exclamation point be too jaunty?)

and here's the big search:

Some things I want to address before this gets merged:

[ ] keyboard navigation doesn't scroll the autocomplete dropdown
[x] #621: submit button should be color: #92D6E5 on hover/focus

khandelwal commented 9 years ago

Is this ready to be reviewed and merged?

ericadeahl commented 9 years ago

@shawnbot Sorry I didn't respond before - looks great! We can just remove the arrow after "Help us improve". I have a slight aversion to unnecessary !!!!!!!!!s :)

shawnbot commented 9 years ago

OK @khandelwal, I think we're good to go here. The keyboard navigation problem can be broken off as its own issue. Better to get the small search out there than to let it languish in this PR!

vz3 commented 9 years ago

This looks good. merging.

18F / 2015-foia-hub

Resurrect small search #646