search

18F / 2015-foia-hub

A consolidated FOIA request hub.
Other
48 stars 17 forks source link

Banner close on tab+enter #727

Closed theresaanna closed 9 years ago

theresaanna commented 9 years ago

Should be merged prior to https://github.com/18F/foia-hub/pull/725 for ease.

Adds commenting around banner persistence and makes it so that if you tab to the close button and hit enter, the banner will shut.

Note that if you click or tab+enter on the button accidentally, it may not be clear how to reopen it? That is likely an enhancement to consider another time.

vz3 commented 9 years ago

Reviewed and merged to banner branch. To be merged with master via #714