search

18F / 2015-foia-hub

A consolidated FOIA request hub.
Other
48 stars 17 forks source link

Expandable help text #736

Closed theresaanna closed 9 years ago

theresaanna commented 9 years ago

I implemented a version of the first pair of mocks here: https://github.com/18F/foia-hub/issues/719. I was unable to make the gray box span the entire width of the sidebar as the structure of the sidebar's CSS doesn't allow for it. Here's what I implemented:

screen shot 2015-04-16 at 8 33 47 am

The gray box slides up/down like the banner.

khandelwal commented 9 years ago

@theresaanna Thanks for helping out with this. So much :heart:.

khandelwal commented 9 years ago

Fixes #719

khandelwal commented 9 years ago

I've added in the correct definitions to each of these. screen shot 2015-04-20 at 9 11 52 am

khandelwal commented 9 years ago

@ramirezg Will our analytics tell us when someone expands a definition, and which definition they expand?

khandelwal commented 9 years ago

@theresaanna 's changes look good to me. @rjmajma I need you to review the content, and then merge this in if you're happy.

geramirez commented 9 years ago

@khandelwal No not yet, I can add the trackers in these and banner.

khandelwal commented 9 years ago

@ramirezg Let's do that as a separate pull request.

geramirez commented 9 years ago

@khandelwal Just added the analytics to 18F/foia-hub/pull/737 @theresaanna do you mind taking a look to make sure I didn't ruin any of the js?

geramirez commented 9 years ago

:+1: toggled the definitions at least 100 times while testing the analytics these work great.