search

18F / 2015-foia-hub

A consolidated FOIA request hub.
Other
48 stars 17 forks source link

cleaning load_agency_contacts #774

Closed geramirez closed 9 years ago

geramirez commented 9 years ago

I ran the tests with coverage to look for testing gaps. Changes: The check_urls function isn't used so I removed it along with anything below the -if __name__ == "__main__": statement.

I also realized that we didn't test adding office stats so I added an additional test and found a possible edge case the might cause office stats to not update.

khandelwal commented 9 years ago

Please document this pull request by adding more comments to it. Why are you removing everything in the deploys/ directory?

You added a random test. How is this related to what looks like a directory cleanup?

khandelwal commented 9 years ago

Now that we're in production, let's be very explicit about how we document changes like this. It'll help us keep track.

geramirez commented 9 years ago

@khandelwal you're right let me clean this up.