search

18F / Sendak

[DEPRECATED] Sendak integrates user, project, and deployment management for 18F
Other
10 stars 4 forks source link

Plugsuit #97

Closed janearc closed 9 years ago

janearc commented 9 years ago

this is the merge-in of plugsuit. it lays the groundwork for shared state, shared config, shared code, which was not possible in the "previous setup", wherein all code was self-contained and atomic. this can be considered a "redesign" of sorts, but also adds a lot of functionality in terms of debugging (which is useful on a project of this size), unit testing (which has been a long-standing issue) and should make the code generally more robust.

janearc commented 9 years ago

it looks like travis is asking for singleton, which doesn't seem to actually be requested in the tree.

konklone commented 9 years ago

FWIW, when I tried to run this locally (a couple hours ago), I also got told that singleton was required.

janearc commented 9 years ago

Yeah I am not sure why that is. Nobody is using it. I grepped through Sendak and didn't find it. If you can find it, I will definitely buy you a cookie. :)

janearc commented 9 years ago

(caveat: a couple things, like deep-grep are using singleton, but that should be handled in those packages)