search

18F / agile

Agile Principles and Practice, documented by the 18F Agile Guild
https://agile.18f.gov
Creative Commons Zero v1.0 Universal
46 stars 33 forks source link

Migrate to isildurs-bane template #118

Closed ryanhofdotgov closed 3 years ago

ryanhofdotgov commented 4 years ago

Migrate to isildurs-bane template, which uses latest uswds-jekyll:

ryanhofdotgov commented 4 years ago

With a couple of very minor exceptions, I've made no changes to the content. Perhaps in another PR, you may want to change the TTS Agile Guild bit to 18F Agile Collective?

Once this is merged in, then I can configure CircleCI which will run a link checker, etc.

ryanhofdotgov commented 3 years ago

@julialeague @alexbielen Any thoughts on proceeding with or rejecting this PR? If I consider my meta-template as a product, you all are my first set of customers that I've pursued beyond my own use (i.e., the Engineering guide). I won't take it personally if you don't think there's a product-market fit 😁

And just to clarify, all the isildurs-bane code, GitHub Actions, etc. has been (and will continue to be) peer reviewed within 18F/TTS, so no obligation to inspect all of that code merged in this PR unless you would like to.

If you would like to see what it looks like for a downstream guide to automatically sync with the isildurs-bane template, check out: https://github.com/18F/development-guide/actions

Non-content related fixes or dependency updates get done in the template repo (e.g., https://github.com/18F/isildurs-bane/pull/46, https://github.com/18F/isildurs-bane/pull/45, https://github.com/18F/isildurs-bane/pull/44) and a GitHub Action gets executed daily to pull those down into any downstream guides.

Currently just the Engineering guide is downstream, but the idea is that the TTS Engineering Practices leads do any fixes once, and then any subscribed guides benefit, like a library, except for all the moving parts at the repo level (e.g., CircleCI, docker, automated tests for links, accessibility, Ruby versions, etc.).

julialeague commented 3 years ago

@ryanhofdotgov Oh no, Ryan! I'm sorry I dropped the ball on this. Let me know if I can help get this updated and merged - I'll be sure to carve time in my calendar for it!

ryanhofdotgov commented 3 years ago

@julialeague No worries. It didn't end up being a solution that was super interesting to any guide maintainers (except for me 😄 ) and I ended up running into a bit of a wall on protected branches, so I've just chalked it up to a less-than-successful experiment and decided to shelve the effort: https://github.com/18F/isildurs-bane#this-template-is-deprecated