18F / archived-guides

A collection of 18F guides.
https://guides.18f.gov
Other
20 stars 12 forks source link

Match header name to GitHub repo name #24

Closed jessieay closed 8 years ago

jessieay commented 9 years ago
baccigalupi commented 9 years ago

Sweet! I love your commit and pull request message too.

I don't have enough context to know how this impacts functionality though. Probably someone else should weigh in on this too.

mbland commented 8 years ago

@baccigalupi In many of the individual guides, we have to take care to keep the sidebar in sync with individual page titles; in most guides at this point, the ./go update_nav command will help with this per https://pages.18f.gov/guides-template/update-the-config-file/#register-new-pages. The critical thing is that the title of the page match exactly the title listed in the sidebar so that the little blue sidebar highlight will be generated properly for each page.

In this case, the sidebar is a launch pad to other guides, so there's not the same concern. I also think it's nice to match the title with the repo. @emileighoutlaw may have something to say about the capitalization of the titles, but we can always fix that with a follow-up PR.

jessieay commented 8 years ago

@mbland Thanks for the review/merge! :+1: