Open brittag opened 8 years ago
Here's another weird thing about definitions especially in 479 - I'll just add this here instead of making a fourth issue about definitions in 479!
479 defines the word "firearms" in a special way - to mean "specific types of firearms covered by the special requirements of the National Firearms Act" instead of the usual meaning of firearm (such as the broader definition in 478). This makes clicking "Firearms" in the phrase "Bureau of Alcohol, Tobacco, Firearms, and Explosives" a little weird, since that's not the definition of what "firearms" means in that phrase (since ATF is about firearms in general):
Part 555 defines "act", and there are some incorrect definitions for unrelated uses of the word "act", such as:
I've created a simple extension to track phrases we want to exclude, and all that needs to be done is to add phrases to a list. For example, after I added make such return
to the exclusions for 479, the last make
in 479.151 isn't linked to a definition in my local build.
I added an issue for act
in 555: https://github.com/18F/atf-eregs/issues/411
In 479, "make" has a specific definition because the regulation is partially about making firearms. But the regulation also uses the word "make" for unrelated purposes, such as when talking about recordkeeping in § 479.151 Failure to make returns: Substitute returns.:
We should check the search results for "make" in this regulation and make exceptions to this definition when it's not the right definition.
This is similar to the issues I filed at https://github.com/18F/atf-eregs/issues/331 ("receiver") and https://github.com/18F/atf-eregs/issues/337 ("director").