search

18F / atf-eregs

Container and styles for an ATF eRegs instance
https://regulations.atf.gov/
Other
9 stars 20 forks source link

Reduce amount of custom CSS #433

Closed cmc333333 closed 8 years ago

cmc333333 commented 8 years ago

We had be overriding whole LESS files, which is problematic as we modify -site. Since working on ATF, we've switched to a more layered approach, placing custom styles on top of the base set where it makes sense. This PR removes all of the copy-paste styles and moves custom styles into their own modules.

The strategy isn't perfect, as we relied on the order of inclusion in a few situations, but I've visually compared the modified CSS to the styles on demo.

donjo commented 8 years ago

I wasn't super familiar with how ATF is supposed to look so here are a few things I noticed between this and the public version

screen shot 2016-06-16 at 5 17 26 pm

table of contents is huge.

Also that line below is double thick. I think you may be able to remove 

.subpart-heading {
    border-top: 1px solid #d1d3d5;
}

to make it uniform (also I feel like there was an issue about this somewhere)

donjo commented 8 years ago

A similar issue affects more things on the second tab.

screen shot 2016-06-16 at 5 22 34 pm
cmc333333 commented 8 years ago

We must be overriding the template, which was modified in at the end of last week: eregs/regulations-site#408. I'll take a look!

cmc333333 commented 8 years ago

@donjo actually, I'm not seeing these issues locally. Do you have latest -site (pip install -r requirements.txt) and have you recompiled the frontend?

donjo commented 8 years ago

:facepalm: you're right, I forgot to re-compile when I was moving stuff around. I think it's all good to go.