Change defined term link colors

[tadhg-ohiggins]

Change the colors of the defined terms in the regulations.

I'm pretty sure that adding these CSS elements to https://github.com/18F/atf-eregs/blob/master/atf_eregs/static/regulations/css/scss/module/custom/_typography.scss will do it, but I'm not sure what the colors should actually be.

.definition,
.definition:link,
.definition:visited {
}

.definition:hover,
.definition:active {
}

.definition.active {
}

[cmc333333]

In thinking about the above, try to delineate what should be part of "core" and what's an ATF-specific thing, too.

[jehlers]

Sorry for the late response.

This is the "current" terms color on production now (via inspect):

That ^^ #D1D3D5 is the one we should keep for the "core" platform.

For ATF's theme we should switch that gray to #767676

How's that? Did I miss anything?

[tadhg-ohiggins]

Hmm; #D1D3D5 is the $history_drawer_border_color, but the border-bottom for the definition links is set to the $gray_light variable, which is #D8D8D8, so I'm slightly confused about which variable to change.

[cmc333333]

Skimming through where $gray_light is used, I see lots of borders and some text in the header and sidebar. Given how close the two colors are, lets try swapping out $gray_light and pushing that to demo for @jehlers to spot check? I'd like to delete the $history_drawer_border_color (and other one-offs) if possible, but that may be out of scope.

[tadhg-ohiggins]

No-really-this-time fixed by https://github.com/18F/atf-eregs/pull/454 and https://github.com/eregs/regulations-site/pull/467.