18F / brand

18F Brand
https://brand.18f.gov
Other
27 stars 21 forks source link

Ensure consistent alignment & margins #140

Closed juliaklindpaintner closed 5 years ago

juliaklindpaintner commented 5 years ago

There are a couple issues I've noticed in this category:

AvivaOskow commented 5 years ago

Agree with a lot of these and all find that I feel the left margin is too big most of the time for the content I need to fit so I end up breaking it! So maybe considering making the margin smaller, except on section intro/transition pages, that could maybe stay larger (I'm ok with there being a slightly different margin for those since the content/layout is different, if that doesn't confuse people)

cmajel commented 5 years ago

@Dahianna will be investigating this over the next sprint.

Dahianna commented 5 years ago

Here's a deck with updated margins: https://docs.google.com/presentation/d/1jBVvqOLrB2NCJR2J_gEspTToeGeAma0DK-jtoocDLzg/edit?usp=sharing

cmajel commented 5 years ago

@Dahianna this looks great! 🎉

I did adjust a few things, but with these adjustments I think we're good to go

Updated

Screen Shot 2019-06-21 at 2 45 09 PM

Updated

Screen Shot 2019-06-21 at 2 49 58 PM
Dahianna commented 5 years ago

Thanks! I'll go ahead and update the template.

cmajel commented 5 years ago

@Dahianna I was looking at this again this morning and noticed a fix we should make with the preheaders:

In the current deck, the preheader rides a lot closer to the title but the text boxes overlap. Current master deck

Screen Shot 2019-07-03 at 9 26 23 AM

In the updated deck, the text boxes no longer overlap, but the preheader is now much further away:

Screen Shot 2019-07-03 at 9 30 04 AM

I did a demo (slide 18) to see if we can fix this alignment without overlapping the boxes, and we can. Details in slide 18! Updated

Screen Shot 2019-07-03 at 9 37 25 AM

Could we make this adjustment to the preheaders and then update the master theme?

Dahianna commented 5 years ago

Great! I made the updates and new alignments are as follow:

Dahianna commented 5 years ago

Last slide was updated on #172

cmajel commented 5 years ago

@Dahianna I mentioned this in #172 but it appears that the demo deck doesn't have the updates applied to the master, which means I could insert a new slide from the layout gallery and get the old alignment.

Menu I am referring to:

Screen Shot 2019-07-10 at 9 12 53 AM

Is this a part of your next step?

Dahianna commented 5 years ago

I updated master today. I can update the demo deck as well

Dahianna commented 5 years ago

I think this is done, will check during coworking

cmajel commented 5 years ago

This is done and announced! 💯

If future alignment issues come up, please create a separate issue and reference this thread as needed.