fixing button text color, fixing active nav item indicator on mobile

18F / brand

18F Brand

https://brand.18f.gov

Other

27 stars 21 forks source link

fixing button text color, fixing active nav item indicator on mobile #259

Closed cmajel closed 3 years ago

cmajel commented 3 years ago

Fixes a few small styling bugs I noticed at our demo yesterday, including:

Fixing the button text color on the logo page
Fixing the mobile active nav item indicator bar

@igorkorenfeld passing to you for your review! Before and after's below.

Federalist preview link

Button text color

Before

After

Mobile active nav indicator

Before

After

igorkorenfeld commented 3 years ago

Great work catching that mobile menu issue @cmajel ! This is something that I think came up for other guides, and so this is especially great because I think we can create some PRs to fix it on those as well.

The button change works, but I think I may have snuck a fix in the configs PR already. Putting the class on the same line seems to have fixed the text color, so I don't think we need the css rule.

cmajel commented 3 years ago

@igorkorenfeld thanks for catching that. PR updated with that button fix removed.

igorkorenfeld commented 3 years ago

Looks great!