18F / bug-bounty

OUT OF DATE: Internal documentation for TTS's bug bounty.
https://github.com/18F/tts-tech-portfolio/issues/49
Other
9 stars 5 forks source link

[wip] use github auth #6

Closed jacobian closed 7 years ago

jacobian commented 8 years ago

Rather than using Django's built-in auth, admins should auth against github.

jacobian commented 8 years ago

Or maybe we should use github instead? /cc @adelevie

NoahKunin commented 8 years ago

Why is MyUSA being considered? It's on the line to deprecation due to Login. I'd use GitHub auth until Login is up.

jacobian commented 8 years ago

github it is 👍

jessieay commented 8 years ago

@jacobian thoughts on scoping to https://github.com/orgs/18F/teams/18f so only 18F staff can auth rather than anyone in the 18F org? (197 vs 346 ppl)

jacobian commented 8 years ago

@jessieay it's hard to tell, but that's what this does, see https://github.com/18F/bug-bounty/pull/6/files#diff-041953c637f95e25fb35d51022891763R79 - using the GithubOrganizationOAuth2 backend takes care of that. See http://psa.matiasaguirre.net/docs/backends/github.html#github-for-organizations for the (scant) documentation.

jessieay commented 8 years ago

@jacobian I was thinking you'd want GithubTeamOAuth2. -- I think you are using the 18F Org, which is bigger than the 18F Team

jacobian commented 8 years ago

@jessieay oh shit, I'd missed that difference! Yes, you're totally right - thank you!

konklone commented 8 years ago

@jacobian So how much do we pay @jessieay for that one? :smile_cat:

NoahKunin commented 8 years ago

@jessieay http://i.giphy.com/13B1WmJg7HwjGU.gif