add Code Climate static analysis

18F / concourse-compliance-testing

Concourse CI assets for Compliance Toolkit

https://compliance-viewer.18f.gov/

Other

17 stars 7 forks source link

add Code Climate static analysis #19

Closed afeld closed 8 years ago

afeld commented 8 years ago

Ready! I also set up the pull request integration, but not sure why it isn't appearing here.

A couple of engines that I wanted to enable but couldn't:

markdownlint: the rules aren't configurable yet, and they enforce line length default, which I'm pretty strongly opposed to.
nodesecurity: it complains that there isn't a package.json at the top level of the repository. I kinda like keeping tests/dependencies scoped to each task directory, so probably just going to skip this engine.

afeld commented 8 years ago

...but was able to verify locally.

$ docker run \
  --interactive --tty --rm \
  --env CODECLIMATE_CODE="$PWD" \
  --volume "$PWD":/code \
  --volume /var/run/docker.sock:/var/run/docker.sock \
  --volume /tmp/cc:/tmp/cc \
  codeclimate/codeclimate analyze
Starting analysis
Running duplication: Done!
Running eslint: Done!
Running fixme: Done!
Running shellcheck: Done!

Analysis complete! Found 0 issues.

DavidEBest commented 8 years ago

This looks good, but shouldn't we add a ruby engine or two?

afeld commented 8 years ago

We don't have any Ruby in there yet, but I suppose we will soon enough. Added!

mrb commented 8 years ago

Can I just say? :clap: