Closed DavidEBest closed 8 years ago
Not to pile on too much extra work, but would you mind fixing the Code Climate warnings? I want us to get out of the habit of merging things that have a broken build, whether than means that pull requests fix the issues, or change the config so that we don't have to worry about them this and every subsequent time.
@afeld I was looking at them now. I've got to get in the habit of running more than just rubocop
before I issue PRs. :)
Meh, not worth waiting on how to work around the Code Climate issues then.
We ran into an issue with
C2
, which was specified in the targets.json file asc2
, in the team-api asC2
, and as a team-api url asc2
. Since the team-api urls are downcased, it makes the most sense to standardize on that format here.Just downcasing them should prevent tasks further along in the pipeline (or compliance-viewer) from needing to think about this.
Addresses #33