simplify ZAP pipeline interactions with S3

18F / concourse-compliance-testing

Concourse CI assets for Compliance Toolkit

https://compliance-viewer.18f.gov/

Other

17 stars 7 forks source link

simplify ZAP pipeline interactions with S3 #53

Closed afeld closed 8 years ago

afeld commented 8 years ago

The pipeline was previously downloading the results from all projects—this instead downloads the results from the particular project that is being scanned only. It also means we can use the built-in S3 resource, instead of our custom one.

DavidEBest commented 8 years ago

Is this [WIP]? What else needs to be done?

afeld commented 8 years ago

Testing, I suppose. Not sure if I'll get back to it today.

afeld commented 8 years ago

Ready for another review!

ctro commented 8 years ago

Looks good to me! I haven't tested locally yet though.

ctro commented 8 years ago

Works great for me locally, merging.