summarize-zap-results was using the project-data (from the Team API) rather than filtered-team-data (which is the targets.json data merged into the Team API data), which means it was using "name": "C2" rather than "name": "c2". Also cleaned up so that that downcasing happens in one place only.
summarize-zap-results was checking if each alert in the previous and current scans were the same by a handful of attributes—see ZAPResultSet::Result. The evidence and url attributes were causing two equivalent alerts to be considered independent, because each contained some varying data (a random value, the time, etc.). Removed the former and the query string from the latter from the comparison, which means we will have more consistent ZAP notifications in Slack going forward.
Phew, ok, this should finally finally fix https://trello.com/c/y63dRvhw/133-investigate-c2-scans-always-showing-as-new-results. This pull request solves a couple issues:
summarize-zap-resultswas using theproject-data(from the Team API) rather thanfiltered-team-data(which is thetargets.jsondata merged into the Team API data), which means it was using"name": "C2"rather than"name": "c2". Also cleaned up so that that downcasing happens in one place only.summarize-zap-resultswas checking if each alert in the previous and current scans were the same by a handful of attributes—seeZAPResultSet::Result. Theevidenceandurlattributes were causing two equivalent alerts to be considered independent, because each contained some varying data (a random value, the time, etc.). Removed the former and the query string from the latter from the comparison, which means we will have more consistent ZAP notifications in Slack going forward.Phew :sweat_smile: