search

18F / crime-data-explorer

Moved to https://github.com/fbi-cde
73 stars 20 forks source link

Jackson PD Mississippi listed as wrong county #304

Closed bellsworth1 closed 6 years ago

bellsworth1 commented 6 years ago

In the CDE, Jackson PD is listed as Madison County. Jackson is in Hinds County. I spot checked some other agencies in MS and didn't notice others that are listed improperly. Jackson does spill into Madison and Rankin Counties, but is primarily located in Hinds.

LarryBafundo commented 6 years ago

this may have to do with our implementation for agencies that span multiple counties. the approach we (18F & the product owner at CJIS) decided on was to identify a "primary county" for the agency, with "primary county" being based on the proportion of total population covered by the agency.

is that correct @harrisj?

harrisj commented 6 years ago

You are correct in that we assign the primary county based on the one with the highest population. That said, this does seem to be a bug, since this is the actual population counts for the last few years

data_year county_name population
2016 HINDS 169880
2016 MADISON 627
2016 RANKIN 1
2015 HINDS 169880
2015 MADISON 627
2015 RANKIN 1
2014 HINDS 171743
2014 MADISON 632
2014 RANKIN 1

So it should be listed in Hinds County. I will have to look into what is going one, but this is part of how the cde_agencies table is built so the SQL should be in the denorm-agencies.sql script

bellsworth1 commented 6 years ago

FYI, feedback from a CDE user: I realize your website is under development but thought I’d point out that San Antonio Police Department is actually in Bexar County, Texas, not Medina County (https://crime-data-explorer.fr.cloud.gov/explorer/agency/TXSPD0000/violent-crime). Thanks for the great interactive website! I will be sharing it with our partners.

LarryBafundo commented 6 years ago

thanks @bellsworth1

harrisj commented 6 years ago

I've made the fix in the DB (not sure how it happened, but rebuilding the table fixed it), and this should be visible once @jeremiak regenerates a file for the frontend

LarryBafundo commented 6 years ago

looks like Jackson PD (MS) is still showing up as in Madison County instead of Hinds. @harrisj thinks he fixed this issue in the DB, but that the file needs to be regenerated on the FE.

Link: https://crime-data-explorer.fr.cloud.gov/explorer/state/mississippi/violent-crime

Screen Shot 2017-11-06 at 10.39.55 AM.png

LarryBafundo commented 6 years ago

hey @jeremiak any updates on this? still seeing it as Hinds on production.

jeremiak commented 6 years ago

@LarryBafundo 1284 needs to be merged and then we need to do a release for this