search

18F / crt-django

Moved to usdoj-crt/crt-portal
https://github.com/usdoj-crt/crt-portal
0 stars 2 forks source link

Remove duplicate npm install commands from run.sh #16

Closed alexsoble closed 5 years ago

alexsoble commented 5 years ago

@LindsayYoung I noticed the Docker setup scripts run npm install in two places: the Dockerfile, which installs from package.json, and run.sh, which installs a list of packages.

Installing from package.json seems like the more idiomatic approach, and the packages from run.sh appear to be duplicates.

I tried a fresh docker compose build/up on this branch and the USWDS styles appear the same on /form, so I think we can safely remove these lines from run.sh.

LindsayYoung commented 5 years ago

Thanks for finding that! I think that makes sense to me. Then we can add the build steps to install from package.json during the build phase when we automate the deploy.

alexsoble commented 5 years ago

@LindsayYoung 👍👍