Staging server will now manage updating data

18F / dashboard

DEPRECATED: A site to track our projects' status and much, much more...

Other

44 stars 25 forks source link

Staging server will now manage updating data #181

Closed gboone closed 9 years ago

gboone commented 9 years ago

Staging hookshot now will update the data submodule, pull out any private data and push the results back to this repo

gboone commented 9 years ago

@mbland committing the Gemfile.lock failed the build so I ripped it out. It apparently has something to do with running bundle --deployment instead of the normal bundle before bundle exec jekyll build. I think we can merge this and revisit whether we need to commit the Gemfile.lock later. I want to get this moving so we can move on #180.

mbland commented 9 years ago

Hmm, maybe we can take a look at that together tomorrow. Aside from my couple of comments, LGTM, :shipit:, or what-have-you. Feel free to merge yourself, or ping me to hit the button if you prefer.

gboone commented 9 years ago

Turns out you had the same problem https://github.com/18F/hub/commit/29923e6d697da81116ff5cc11ca06ad933983b7a

mbland commented 9 years ago

@gboone This is why GitHub exists. My brain is like a sieve!

gboone commented 9 years ago

All thanks to @monfresh here, I only noticed you had mentioned jekyll/jekyll#2938 after he sent me to the issue.

mbland commented 9 years ago

@gboone Just pushed a commit to address my earlier comment. Mind giving it a quick look and merging?

cc: @leahbannon

mbland commented 9 years ago

Merging with remote approval of @gboone.