18F / dashboard

DEPRECATED: A site to track our projects' status and much, much more...
Other
44 stars 25 forks source link

Contact links from .about.yml/Team API #254

Closed mbland closed 8 years ago

mbland commented 8 years ago

Hey @gboone, you'd mentioned being cool with just getting the data for the contacts: field from the Team API and posting it straight into the template, rather than parsing it as an email address or as a GitHub URL fragment as we do now. Would you want to have just a raw URL (mailto: or https: that you'd post as <a href="{{ contact_url }}">{{ contact_url }}</a>, or have an object with url: and text: fields that you'd render as <a href="{{ contact.url }}">{{ contact.text }}</>?

cc: @monfresh re: 18F/github-dashing#24

gboone commented 8 years ago

Probably contact.url and contact.text I think.

---
contact:
  url: https://blah.blah/blah
  text: Black blah blah

something like that. That seems more extensible for the future, anyway.

mbland commented 8 years ago

Sounds good to me.

cc: @melodykramer @jeremiak

DavidEBest commented 8 years ago

This is how a fully specified contact field looks on staging:

screenshot 2015-10-05 12 06 35

That is based on the following format:

contact:
- url: mailto:michael.bland@acm.org
  text: Mike Bland
- url: https://github.com/18F/hmac-authentication-npm/issues
  text: 18F/hmac-authentication-npm issues

Is that the expected format? If so, I'd be happy to submit a fix.

mbland commented 8 years ago

Yep, that's the new contact: format. A fix is surely welcome, if @gboone or I don't get to it first.

DavidEBest commented 8 years ago

Thanks, @mbland. I'll take a look, then.