search

18F / dashboard

DEPRECATED: A site to track our projects' status and much, much more...
Other
44 stars 25 forks source link

Use plugin to build javascript bundle #329

Closed dhcole closed 8 years ago

dhcole commented 8 years ago

Simple plugin to run npm install on Jekyll build. Also adds npm install script for npm run browserify. This should automatically generate the JS bundle on build in Federalist.

gemfarmer commented 8 years ago

@dhcole I'm revisiting the issue I was having yesterday and unclear on how you are making npm executable within _plugins/build.rb.

For the changes I am making on EITI, I am getting this error in Federalist:

Configuration file: ./_config.yml jekyll 3.0.0.pre.beta9 | Error: No such file or directory - npm

Any thoughts on why it isn't able to run npm?

dhcole commented 8 years ago

This was the result of a missing dependency in the build environment. By default, the nodejs package on Ubuntu does not include NPM, even though it does on other platforms. To fix it, we've updated the build environment's image to include node v4.x, which includes NPM. This error should be resolved.

mbland commented 8 years ago

Looks like this errored out on the current Dashboard site due to noexec permissions on the file system. Jekyll looks like it's still able to build, though.