18F / data-act-pilot

This small DATA Act pilot contains code that translates agency data to a uniform DATA act format.
Other
21 stars 14 forks source link

As an SBA user, I need the submission process to inform me if my file is not formatted in one of the four CSV formats #110

Closed micahsaul closed 9 years ago

micahsaul commented 9 years ago

Acceptance Criteria

msecret commented 9 years ago

I think the plan here was to just validate the CSV for a set of columns. How would I find what the required columns would be?

bsweger commented 9 years ago

Great question--right now, the four .csv templates (with column names) are sitting in an unmerged branch: https://github.com/18F/data-act-pilot/tree/split-file-template/template

(see the files named inventorymapping*.csv, but I'm going to rename them to the names on Andrew's wireframe)

Treasury is working on new set of column names (there's several versions floating around), and we should have those early next week. Not sure how that impacts your decision to move forward here.

msecret commented 9 years ago

@andrewmaier the three potential error conditions that I have now are:

Do we want the UI to display these types of errors? If so, you can let me know what you're thinking, I don't necessarily need a design.

bsweger commented 9 years ago

FWIW, I think the UI should display these types of errors

andrewmaier commented 9 years ago

(File wasn't uploaded at all) || (File isn't of .csv type) || (File has incorrect headers) === File wasn't able to be read

?

msecret commented 9 years ago

Yes, that sounds right