search

18F / development-guide

A set of guidelines and best practices for an awesome software engineering team
https://engineering.18f.gov
Other
1.25k stars 122 forks source link

Adopt USWDS Identifer, replacing UX guide's Anchor #261

Closed ryanhofdotgov closed 3 years ago

ryanhofdotgov commented 3 years ago

This template adopted the UX guide's work, and that implemented a pre-release USWDS component called an Anchor (at the time). This later became Identifier once it was officially released.

The USWDS footer (at least in in the Jekyll template) wasn't designed to work with it exactly, so that lead us to the footer fork you see here. See how we can preserve the styling we adopted from the UX guide, keep the Edit page/last modified date functionality, but get rid of the Anchor-driven fork.

Sgtpluck commented 3 years ago

@ryanhofdotgov since we import the uswds-jekyll does this need to be fixed in the actual template? (i see that they removed identifier ~8 months ago, not sure why.)

ryanhofdotgov commented 3 years ago

Ah, yes – I think that's right.

Digging into the related PR, there was some initial discussion on the product vision for the theme.

Here's a separate PR where that conversation continued.

Sgtpluck commented 3 years ago

Closing because this handbook is being merged into the TTS handbook, rendering it moot.