Update instructions for Docker Desktop

18F / development-guide

A set of guidelines and best practices for an awesome software engineering team

https://engineering.18f.gov

Other

1.25k stars 122 forks source link

Update instructions for Docker Desktop #310

Closed SSPJ closed 2 years ago

SSPJ commented 2 years ago

Appears to have been bitten by https://github.com/pa11y/pa11y-ci/issues/128. I'll check by running on my local when I have a free moment.

geekygirlsarah commented 2 years ago

Appears to have been bitten by pa11y/pa11y-ci#128. I'll check by running on my local when I have a free moment.

@bklaas didn't you fight this on an issue on the guide in the past? Do you remember what you did to fix it?

echappen commented 2 years ago

Yeah pa11y fails intermittently (we need to look into why). You can try running it again and that usually works.

Sgtpluck commented 2 years ago

This pa11y issue appears to be an issue with jekyll's default markdown generator 🙈 see relevant pr here. it seems like it's a true accessibility bug with the way it's applying the role to the footnotes of the on-call pages.

solutions are:

ignore it for the moment, since hopefully it will be fixed soon (it looks like someone started paying attention to that bug today)
contribute???
something complex that involves not using the default footnotes ???
get rid of the footnotes and add the relevant details in-line with the rest of the text

Sgtpluck commented 2 years ago

@echappen @svenaas what do you think of the options?

echappen commented 2 years ago

For this PR in particular, I say we go with 1) ignore—fixing footnotes across the site should probably be its own issue.