search

18F / development-guide

A set of guidelines and best practices for an awesome software engineering team
https://engineering.18f.gov
Other
1.25k stars 122 forks source link

Add suggestion to use Allstar to enforce consistency across repos #321

Closed markdboyd closed 2 years ago

svenaas commented 2 years ago

This looks good to me. @Sgtpluck, you've done a fair bit of work in this file. Would you like to review as well?

markdboyd commented 2 years ago

@Sgtpluck How about 58e6ee4d26f2d3d82561a3dcb266e147879d77d9?

Sgtpluck commented 2 years ago

@markdboyd perfect!!! thank you.

Sgtpluck commented 2 years ago

The pa11y failure is fine as per https://github.com/actions/first-interaction/issues/10#issuecomment-545576314 -- it's because the PR is coming from a fork.

markdboyd commented 2 years ago

@Sgtpluck OK, thanks! I don't have access to merge PRs on this repo, so someone else will have to merge for me

svenaas commented 2 years ago

I have merge permission; I was just giving @kbighorse a chance to review too before we press the button.