18F / dol-whd-14c

The 14(c) system will become a modern, digital-first service. Applicants will be provided an intuitive online experience, guiding them through the information needed to complete their application correctly.
Other
16 stars 17 forks source link

Bug: New login workflow: User registration Account confirmation message is missing #577

Closed mmurthydol closed 6 years ago

mmurthydol commented 6 years ago

When a user registers and clicks on the confirmation email link, user is redirected to the login page. However there is no visual clue that the user's account is confirmed.

Acceptance criteria

Uxpin UX specification link that shows the design for account confirmation page: fohttps://preview.uxpin.com/d217c031c2dafec225a80652ee085d04ccafc106#/pages/78317784/simulate/sitemap?mode=i

davoodharun commented 6 years ago

This was a bug that came about after new login workflow implementation. The account crated dialog existed previously but was inadvertently disabled with the work for the new workflow. I have fixed this issue in #581

mmurthydol commented 6 years ago

Thanks Harun for the fix and also the explanation (that helps!) :)

EStriegel commented 6 years ago

User does not currently see the banner when clicking on the link in email confirmation. Believe this is a security requirement. Moving to top of backlog. @mmurthydol

mmurthydol commented 6 years ago

@EStriegel You meant banner page correct? Could you also please check if DOL header/footer are missing? I expect that as well. @binwang89 Michelle, could you please check if this page is 508 compliant if not already? Thanks

EStriegel commented 6 years ago

@mmurthydol So when you create create a user, and click the confirmation link, it takes you to the account confirmed page. There's a link to log-in, which takes you back to the landing page. My understanding is that when the user clicks the confirmation page, they need to see the banner page before the account confirmed page. (The current banner page that you see when you open the QA link has the header/footer)

I'm ok moving this story to done as long as we create a new story saying that the banner page is a precursor to all entries in to 14c from a security perspective regardless of which way we enter the application.