18F / dol-whd-14c

The 14(c) system will become a modern, digital-first service. Applicants will be provided an intuitive online experience, guiding them through the information needed to complete their application correctly.
Other
16 stars 17 forks source link

Reset Password Page doesn't compare passwords entered for equality #853

Closed mmurthydol closed 5 years ago

mmurthydol commented 5 years ago

image

PrabhakarThummalaDOL commented 5 years ago

The 'new password' and 'confirm password' functionality to be review all the following scenarios:

  1. User Registration
  2. Change Password (Your Account)
  3. Forgot/Reset Password
  4. Change Password (from Admin page)
  5. Reactivate a User.
EStriegel commented 5 years ago

@PrabhakarThummalaDOL

Please put the new error message in the red box (and delete "An error occurred while resetting your password, Please try again later if the error persists). We do not need the smaller error message under password.

image

EStriegel commented 5 years ago

@PrabhakarThummalaDOL

Tested the Your Account page. Only edit would be to remove the smaller red exclamation point.

image

EStriegel commented 5 years ago

@PrabhakarThummalaDOL User Registration looks good.

@mmurthydol @binwang89 Can you test the below change password occurrences? Not critical for launch as they are internal. Change Password (from Admin page) Reactivate a User.

binwang89 commented 5 years ago

@EStriegel @PrabhakarThummalaDOL the small error message above the password has been removed. however, the smaller red exclamation point is still there. image

image

binwang89 commented 5 years ago

@EStriegel @PrabhakarThummalaDOL tested it in user registration and where should we show the error message ? the smaller error message under password ? image

binwang89 commented 5 years ago

@PrabhakarThummalaDOL @EStriegel tested in Change Password (from Admin page), see below for screenshot image image

binwang89 commented 5 years ago

@EStriegel @PrabhakarThummalaDOL tested it for Reactive account, please see the screenshot below

image

binwang89 commented 5 years ago

@PrabhakarThummalaDOL @EStriegel tested in Forgot/Reset Password, please see the result

image

NathayaMDOL commented 5 years ago

Completed!

binwang89 commented 5 years ago

@mmurthydol @PrabhakarThummalaDOL @NathayaMDOL retested the Reactivate a User, i did not get the email to reset the password last time.

binwang89 commented 5 years ago

@mmurthydol @PrabhakarThummalaDOL @NathayaMDOL done on testing, i uploaded the latest screenshots for each test case. #853.docx

binwang89 commented 5 years ago

@NathayaMDOL @PrabhakarThummalaDOL @mmurthydol Re-tested, it looks good now.