18F / dol-whd-14c

The 14(c) system will become a modern, digital-first service. Applicants will be provided an intuitive online experience, guiding them through the information needed to complete their application correctly.
Other
16 stars 17 forks source link

Bug: Forgot Password Email text field default verbiage is incorrect. #866

Closed mmurthydol closed 5 years ago

mmurthydol commented 5 years ago

image

Usually, you don’t use both form labels and placeholders with the same text. image

Please use text that is standardized for all text fields. (please ask Liz/Madhu for input). Should be something like "Enter Email Address" and/or with an example. Ideally this pattern must be followed through out the App. But fix is for this field only. But let's discuss with Liz about the whole App if a pattern doesn't exist. @EStriegel

NathayaMDOL commented 5 years ago

For this issue, most of the fields are blank (no placeholder). So I decided to go with blank and make it as a standard for the whole site (remove a placeholder). The screenshot below is an example. @EStriegel let me know if this issue needs to apply with any text pattern in the future.

image

EStriegel commented 5 years ago

@NathayaMDOL Sounds good. Yes, let's keep this pattern in the future.

mmurthydol commented 5 years ago

@NathayaMDOL : How many other places are there to change in the App? If there aren't many, let's go ahead and make the change. We can discuss during stand up if there are any questions. We will add this to the other patches that I am planning for production next Monday - which means we should be done with this on Thu + testing.

NathayaMDOL commented 5 years ago

@mmurthydol, the fixes are already on dev. The changes are below.

  1. Manage Users page: Reset password
  2. Your Account page: Change password
  3. Reactivate page
  4. Forgot password/Reset password page
EStriegel commented 5 years ago

@NathayaMDOL @binwang89 Confirmed on application pages (your account page and forgot password).

Michelle, can you confirm on admin screens and close this story?

binwang89 commented 5 years ago

@NathayaMDOL @EStriegel tested in admin account for Manage user page:reset the password.

image

binwang89 commented 5 years ago

@NathayaMDOL @EStriegel Reactivate the account, please see below screenshots

image

image

image