Add support for new OO-style scanners to ./scan

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.

Other

369 stars 139 forks source link

Add support for new OO-style scanners to ./scan #232

Closed tadhg-ohiggins closed 6 years ago

tadhg-ohiggins commented 6 years ago

The old and the new Sometimes have to co-exist. Let fitness decide.

This adds support for a new style of object-oriented scanner but still supports the older style. This means a lot of code repetition, but we can hopefully cut that down over time.

Supporting both for a while also means that we can incrementally switch them over.

This initial checkin only added an abstract base class approach for noop.py in the form of noopabc.py as a proof-of-concept.

konklone commented 6 years ago

@tadhg-ohiggins Is this ready for merge yet? I'm comfortable moving forward with the PR as it is.