search

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.
Other
370 stars 137 forks source link

Fix some issues with gather options parsing with hyphenated sources #239

Closed konklone closed 6 years ago

konklone commented 6 years ago

Gatherer names like censys-snapshot were failing, because of argparse's automatic hyphen->underscore conversion. This led to nargs=1 not being set for them, as well as the gather script not matching up the stated source name with the keys in the options dict.

This fixes that, and also ditches one of the restrictions around checking whether some flags are gatherer-specific. It seemed unnecessary to keep this mapping maintained over the long run.

konklone commented 6 years ago

Added a commit that adds the --output flag, also used for gathering.

konklone commented 6 years ago

@tadhg-ohiggins I can't figure out why the tests are failing or how to fix them. It makes sense that tests would fail, since I changed some behavior, but I'm at a loss for how to understand the test output or which cases are failing.

konklone commented 6 years ago

Added another commit fixing --analytics for the analytics scanner.