Packaged version of sslyze in lambda/envs/domain-scan.zip is out of date

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.

Other

369 stars 139 forks source link

Packaged version of sslyze in lambda/envs/domain-scan.zip is out of date #251

Closed buckley-w-david closed 6 years ago

buckley-w-david commented 6 years ago

In attempting to use a deployed sslyze scanner, the lambda function threw an error when attempting to execute this line:

from sslyze.server_connectivity_tester import ServerConnectivityTester, ServerConnectivityError

I investigated the domain-scan.zip packages, and see that this seems to be the case because the packaged version of sslyze is 1.1.5, whereas according to the requirements file sslyze needs to be version 1.4.1 or greater.

jsf9k commented 6 years ago

This issue should be corrected in dhs-ncats/lambda_functions. You may prefer to use that project to build your own zip files for AWS Lambda.

buckley-w-david commented 6 years ago

Thank you for the tip.

Do you think that information should be added the docs?

jsf9k commented 6 years ago

I'd say yes, particularly if domain-scan.zip isn't being updated. It should probably be mentioned in the main README.md as well as in docs/lambda.md.

You're also welcome to flesh out the documentation of dhs-ncats/lambda_functions itself, if you think it's lacking.

buckley-w-david commented 6 years ago

Closing due to #252