search

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.
Other
370 stars 137 forks source link

Relying on Python 3.6+ now #262

Closed konklone closed 6 years ago

konklone commented 6 years ago

Newer versions of domain-scan now rely on Python 3.6+, due to the use of Path.resolve() that was added in some recent-ish PRs. Since upgrading from 3.5->3.6 should be pretty painless these days, it seems easier to just bump the documented minimum requirement to match.

Fixes #261.

jsf9k commented 6 years ago

You'll need to change the CircleCI configuration too, right? I can't think of anything else that may depend on the python versions supported.

konklone commented 6 years ago

@jsf9k Good catch - I'd actually done a search for 3.5 in the repo, but it didn't turn that up. I updated the PR with that change. I also can't think of another place where it would be present.