18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.
Other
369 stars 139 forks source link

Cast the port string into an integer #273

Closed jsf9k closed 6 years ago

jsf9k commented 6 years ago

sslyze 2.0 is pickier about types, and passing the port as a string here was causing sslyze to fail.

For HTTPS scanning the port is not specified (the default of 443 is used), so this bug was only impacting folks like me who are using sslyze against other ports.

jsf9k commented 6 years ago

Once #275 gets merged, just merge in master and the CircleCI build should pass.

jsf9k commented 6 years ago

Thanks @IanLee1521!