18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.
Other
370 stars 137 forks source link

Remove now-broken hack and replace with proper solution #276

Closed jsf9k closed 6 years ago

jsf9k commented 6 years ago

Originally a hack was put in place to disable automatic Lambda retries because boto3 lacked support for this. Unfortunately this hack no longer works with the latest boto3 code because it touches internal variables that apparently have been removed or renamed. Fortunately, though, support for disabling automatic retries has been added.

jsf9k commented 6 years ago

This is a pretty big deal, since domain-scan is broken right now if you do a fresh install or upgrade boto3 to the latest.

IanLee1521 commented 6 years ago

See also: https://github.com/boto/botocore/pull/1260