Do not hard code the DNS servers to use for the trustymail scanner

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.

Other

369 stars 139 forks source link

Do not hard code the DNS servers to use for the trustymail scanner #296

Closed jsf9k closed 5 years ago

jsf9k commented 5 years ago

These should be specified on the command line if needed.

I've tested this with the NCATS BOD 18-01 scanning and it works great for our purposes. The reason I made this change is that we were running into a connection tracking limit in AWS, and using the AWS DNS instead of reaching out externally to Google reduces the problem considerably.

jsf9k commented 5 years ago

Thanks @IanLee1521! Now if only CircleCI would cooperate :)

IanLee1521 commented 5 years ago

Yup, I'm sitting here with it open watching!