search

18F / domain-scan

A lightweight pipeline, locally or in Lambda, for scanning things like HTTPS, third party service use, and web accessibility.
Other
371 stars 137 forks source link

Better explanation for https://github.com/18F/domain-scan#setting-tool-paths #49

Closed ArcTanSusan closed 8 years ago

ArcTanSusan commented 8 years ago

The current instructions aren't clear about where/how to set the environmental variables required for localdev.

konklone commented 8 years ago

No? I generally feel like environment variables are so standard in Unix environments that I'm comfortable letting people set that in whatever way works for them.

I use autoenv, would adding a mention of that improve the documentation?

ArcTanSusan commented 8 years ago

It's better to be explicit with the installation instructions than assume that new contributors know how to do a thing.

I'm :+1: to mentioning autoenv.

konklone commented 8 years ago

@onceuponatimeforever does #50 help?