search

18F / epa-notice

Web interface for viewing and commenting on proposed changes to federal regulations
Other
7 stars 17 forks source link

Notice and Comment Homepage #251

Closed xtine closed 8 years ago

xtine commented 8 years ago

Initial template and design styles for the landing page (homepage). #219

screen shot 2016-05-03 at 5 24 45 am screen shot 2016-05-03 at 5 24 59 am screen shot 2016-05-03 at 5 25 06 am screen shot 2016-05-03 at 5 25 12 am
xtine commented 8 years ago

Responsive mobile layout:

screen shot 2016-05-03 at 6 05 00 am screen shot 2016-05-03 at 6 05 09 am screen shot 2016-05-03 at 6 05 23 am screen shot 2016-05-03 at 6 05 34 am
xtine commented 8 years ago

Tablet sizing:

screen shot 2016-05-03 at 6 09 26 am
cmc333333 commented 8 years ago

Should about.png be replacing hero.png rather than adding a new image?

cmc333333 commented 8 years ago

Small detail, but I asked John to do the same: there are lots of magic numbers here. Is there a way to 1) standardize so that they are less per-element 2) use variables or relationships between variables ? Both would up the maintainability.

Looks really nice though, @xtine, all my nits are minor.

xtine commented 8 years ago

The hero.png image in regulations-site is actually slightly different than about.png in notice-and-comment than just image height cutoff, most notably the ToC highlight is green in hero.png, and blue in about.png.

xtine commented 8 years ago

Set 100px paddings between sections controlled via @section_padding variable (except for hero which doesn't have as large a space between next section).

cmc333333 commented 8 years ago

:+1: excited to see this