18F / epa-notice

Web interface for viewing and commenting on proposed changes to federal regulations
Other
7 stars 17 forks source link

Fix read/write tab colors #259

Closed xtine closed 8 years ago

xtine commented 8 years ago

Make sure Read and Write tab colors are correct, per #256

screen shot 2016-05-09 at 12 50 02 pm

When hovering over Write tab:

screen shot 2016-05-09 at 12 55 31 pm
donjo commented 8 years ago

I think maybe we should do a lighten(10%, @grey) (or whatever the variable is for the navbar) for the background color when hovering over the non-active tab. Taking white out makes sense but I think it should have a little bit of a button effect.

donjo commented 8 years ago

Another thing that changed at some point (which is probably what made that link blue in the first place) is causing the icon of the active tab to be too close to the text. The text for the active tab should get a padding: 0 5px which used to be applied by a .preamble-header span rule that still applies to the inactive tab but not the active one.

xtine commented 8 years ago

So there was a few padding changes due to the fact that mobile hides the "the proposal" and "a comment" text. I've added left padding to the active mode link to account for that.

screen shot 2016-05-10 at 10 56 52 am
xtine commented 8 years ago

@donjo: I added the lighten gray hover on the non-active tab and the hover gives a nice pop effect. Good suggestion:

screen shot 2016-05-10 at 11 03 51 am
donjo commented 8 years ago

Looks good 👍

cmc333333 commented 8 years ago

Two thumbs!