search

18F / epa-notice

Web interface for viewing and commenting on proposed changes to federal regulations
Other
7 stars 17 forks source link

Keep user's scroll position on screen after using "show more context" #293

Open tadhg-ohiggins opened 8 years ago

tadhg-ohiggins commented 8 years ago

Currently, using the “show more context” links that are above the user's current position will lose the user's place because it's inserting more content above where they were. This would fix that and return them to where they were after expanding the hidden content.

cmc333333 commented 8 years ago

@tadhg-ohiggins thinking through this, I'm not sure there's a workable solution.

Say the user is reading something but wants the context above what this change. If I understand you correctly, you're saying we should scroll down to the changed text they were looking at.

Now assume that the context was below the diffs. We'd need to keep the cursor in the same position.

Unfortunately, we don't know what the user is focusing on prior to expansion. What we do right now aligns with the latter scenario, but not the former.

yowill commented 8 years ago

Nice to have, difficult to figure out a perfect solution, but will not fix. Too many UI issues, need to figure out a whole manner of ways to fix this problem so we're punting on it.

yowill commented 8 years ago

"By design (label) we mean UI more than visual"