search

18F / epa-notice

Web interface for viewing and commenting on proposed changes to federal regulations
Other
7 stars 17 forks source link

Clean template for Review disclaimer show more/less toggles #304

Closed xtine closed 8 years ago

xtine commented 8 years ago

Disclaimer template for Review page cleanup: remove ids and data attributes for toggling, include show less toggle markup.

Relies on CSS/JS changes on eregs/regulations-site#352

cmc333333 commented 8 years ago

Just to verify, why are aria labels set to hidden initially? Shouldn't they all be visible unless the user has JS, in which case the attributes get set? That'd be the analog to display: none styles, yes?

xtine commented 8 years ago

You're right, and eregs/regulations-site#355 also addresses this.

cmc333333 commented 8 years ago

:+1: