search

18F / federal-grant-reporting

Improving the experience of federal grant reporting.
Other
1 stars 7 forks source link

Upgrade USWDS to 2.0.3 #90

Closed alexsoble closed 5 years ago

alexsoble commented 5 years ago

User story

As a developer, I want to draw on the latest USWDS CSS and JS.

Acceptance criteria

alexsoble commented 5 years ago

@fureigh Is this directory the source of CSS that gets loaded into the base html template? https://github.com/18F/federal-grant-reporting/tree/master/sam-to-ffr/static

I tried deleting all the contents of this directory locally, but when I re-started the app, I still saw USWDS design system loaded up. Having a hard time finding where that's coming from so I can upgrade it to 2.0.3. Maybe this is related to how Django loads up static CSS?

fureigh commented 5 years ago

@alexsoble Not quite — sam-to-ffr is a Flask prototype from phase two.

Currently, the single audit finding resolution app's USWDS integration is coming from designstandards, specified in Pipfile. That package hasn't been updated since 2017, though, and surely there are examples of other 18F projects using Django and the current version of the USWDS.

For details on other considerations, grep the git log for USWDS and Web Design.

fureigh commented 5 years ago

@alexsoble More clearly stated: you're welcome to upgrade the version of USWDS we're using. :) Just need to update existing template files accordingly.

alexsoble commented 5 years ago

@fureigh Ooooooh, thank you! Hadn't thought to check the Pipfile but now that you mention it, that makes sense. I feel unblocked now. 😄

fureigh commented 5 years ago

Continuing the conversation at https://github.com/18F/federal-grant-reporting/pull/97. :)

alexsoble commented 5 years ago

Resolved by #97.