Unspecified Roles in Rules

[ohsh6o]

Extended Description

As a SSP reviewer, to better understand the intent of the validation results categories, I do not want to have rules and results categorized as <not specified>. See example screenshot below.

• Preconditions...

Acceptance Criteria

• [x] A review of rules processing through prototype interface to ensure rules without rules are no longer there.
• [x] Add a mechanism for developers not users to know a rule without a necessary role has been added and will not fall into the categorization scheme.

Story Tasks

Definition of Done

• [x] Acceptance criteria met - Each user story should meet the acceptance criteria in the description
• [x] Unit test coverage of our code > 90% (from QASP) this may be fuzzy and hard to prove
• [x] Code quality checks passed (from QASP) - [ ] Accessibility: (from QASP) as we create guidance or documentation and reports (semantic tagging including aria tags): demonstrate with 0 errors reported for WCAG 2.1 AA standards using an automated scanner and 0 errors reported in manual testing
• [x] Code reviewed - Code reviewed by at least one other team members (or developed by a pair)
• [x] Source code merged - Code that’s demoed must be in source control and merged
• [x] Code must successfully build and deploy into staging environment (from QASP): this may evolve from xslt sh pipline into something more - [ ] Security reviewed and reported - Conduct vulnerability and compliance scanning. threat modeling? - [ ] Code submitted must be free of medium- and high-level static and dynamic security vulnerabilities (from QASP) - [ ] Usability tests passed - Each user story should be easy to use by target users (development community? FedRAMP FART team) - [ ] Usability testing and other user research methods must be conducted at regular intervals throughout the development process (not just at the beginning or end). (from QASP)
• [x] Code refactored for clarity - Code must be clean, self-documenting
• [x] No local design debt
• [x] Load/performance tests passed - test data needed - saxon instrumentation - [ ] Documentation generated - update readme or contributing markdown as necessary. - [ ] Architectural Decision Record completed as necessary for significant design choices

[ohsh6o]

This did not come up in standup today: are we waiting for this to be complete for wrap-up because of the "Add a mechanism for developers not users to know a rule without a necessary role has been added and will not fall into the categorization scheme" AC requirement? @danielnaab and @GaryGapinski, do we need to talk about finalizing pre-commit hooks tomorrow during standup?

[GaryGapinski]

@danielnaab has merged related changes, so I think this can be closed.