Remove Python build dependency

[danielnaab]

Extended Description In order to simplify build environments on Windows, it would be helpful to not require Python installation. Consider replacing a validations test - src/validations/bin/assert-svrl.py - with a bash script.

This is low priority.

Acceptance Criteria

• [ ] Python not required to build/test on Windows.

Story Tasks

• [ ] Tasks…

Definition of Done

• [ ] Acceptance criteria met
• [ ] Unit test coverage of our code > 95%
• [ ] Automated code quality checks passed
• [ ] Security reviewed and reported
• [ ] Reviewed against plain language guidelines
• [ ] Code must be self-documenting
• [ ] No local tech debt
• [ ] Load/performance tests passed – needs to be created/automated
• [ ] Documentation updated
• [ ] Architectural Decision Record completed as necessary for significant design choices
• [ ] PR reviewed & approved
• [ ] Source code merged

[wesley-dean-gsa]

When attempting to run make test on a Linux system with python 3.8 installed, I received a build error:

+ '/var/lib/jenkins/workspace/Source Code Tests/ASAP/src/validations/bin/assert-svrl.py' src/validations/report/test/sch.svrl.xml
  File "/var/lib/jenkins/workspace/Source Code Tests/ASAP/src/validations/bin/assert-svrl.py", line 18
    """)
      ^
SyntaxError: invalid syntax

The aforementioned system has 3.8 and 3.9 installed; however, the system-level default is 3.8. When running on a system with 3.9 as the default, make test works great. No problems.

My plan was to request to update evaluate-compiled-schematron.sh to accept as a parameter the Python binary (e.g., if "${BASE_DIR}/src/validations .... => if "${PYTHON_BIN:-python} ${BASE_DIR}/src/validations ...)

However, if the plan is to refactor this as a shell script, then none of this matters...

[wesley-dean-gsa]

I added a step in my Jenkins configuration to "fix" the script (i.e., tell it to use Python 3.9) before it runs make test:

sed -i~ -Ee 's|if[[:space:]]*"[[:space:]]*(\$\{BASE_DIR\}/src/validations/bin/assert-svrl\.py")|if python3.9 "\1|' src/validations/bin/evaluate-compiled-schematron.sh

This allows make test to complete successfully.